Skip to content

[release-1.16] Remove deprecated HPAContainerMetrics feature gate from templates #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

[release-1.16] Remove deprecated HPAContainerMetrics feature gate from templates #5244

merged 1 commit into from
Nov 13, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Nov 5, 2024

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

Manual cherry-pick of #5242:

This PR fixes an error when running ci-version templates with bleeding-edge Kubernetes that includes this change to remove a feature gate that we reference in templates: kubernetes/kubernetes#126862

This is the error that pops up in the kube-controller-manager logs:

E1105 21:29:48.482259       1 run.go:72] "command failed" err="unrecognized feature gate: HPAContainerMetrics"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.82%. Comparing base (74f38f2) to head (5a507cd).
Report is 3 commits behind head on release-1.16.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.16    #5244   +/-   ##
=============================================
  Coverage         52.81%   52.82%           
=============================================
  Files               273      273           
  Lines             29143    29143           
=============================================
+ Hits              15392    15394    +2     
+ Misses            12949    12947    -2     
  Partials            802      802

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mboersma
mboersma approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b7e9798428a3dae40bed8e3636ffb2e444068d3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 449ecde into kubernetes-sigs:release-1.16 Nov 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojnhuh @k8s-ci-robot @mboersma